Fix headed Chrome screenshot #93
Merged
+59
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearfriend
force-pushed
the
chrome-headed-screenshots
branch
from
7df44f8
to
06f8c3f
Compare
dlockhart
reviewed
Jul 26, 2023
| @@ -30,6 +30,7 @@ export async function focusElem(elem) { | |||
|
|
|||
| export async function hoverAt(x, y) { | |||
| await sendMouse({ type: 'move', position: [x, y] }); | |||
| if (window.d2lTest) window.d2lTest.hovering = true; | |||
There was a problem hiding this comment.
Would having the vdiff/pause stuff just add a listener on the window or body for mouseover also work? If so, it might be nice for that code to live over there where it belongs.
There was a problem hiding this comment.
Talked offline. Sticking with this for now to avoid overusing inlineStyles, which is yucky and slow.
bearfriend
force-pushed
the
chrome-headed-screenshots
branch
from
06f8c3f
to
2e72225
Compare
dlockhart
approved these changes
Jul 26, 2023
Yeah, I'd definitely like to get rid of it sooner rather than later if possible. |
|
🎉 This PR is included in version 0.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes headed Chrome screenshots by inlining all styles to capture hover effects before they break.